Introduce forceRender param #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimKovalenkoSNF
force-pushed
the
1898-introduce-forceRender-param
branch
from
1a68929
to
149fd77
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
- Coverage 71.70% 71.68% -0.02%
==========================================
Files 33 33
Lines 2774 2801 +27
Branches 614 625 +11
==========================================
+ Hits 1989 2008 +19
- Misses 671 680 +9
+ Partials 114 113 -1
☔ View full report in Codecov by Sentry. |
|
@VadimKovalenkoSNF Thank you, please fix codefactor so I can merge. |
Done |
kelson42
requested changes
Sep 7, 2023
src/util/saveArticles.ts
Outdated
| ) { | ||
| DU.deleteNode(section) | ||
| } | ||
| // Mobile view === details |
There was a problem hiding this comment.
Should we not move this (remove empty sections) in the renders code?
There was a problem hiding this comment.
Yes, this moved to the abstract renderer now after rebasing on top of recent changes with #1886
|
@VadimKovalenkoSNF A rebase (with conflict fixing) will be needed here |
VadimKovalenkoSNF
force-pushed
the
1898-introduce-forceRender-param
branch
from
b1019a2
to
9237475
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
forceRenderparam to CLI, this is an enhancement for #1887